Support math trunc #2653
Open
Support math trunc #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titaiwangms
added
the
module: torchlib
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
==========================================
- Coverage 70.46% 70.45% -0.01%
==========================================
Files 224 224
Lines 26572 26576 +4
Branches 2637 2637
==========================================
+ Hits 18723 18725 +2
- Misses 6928 6930 +2
Partials 921 921 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Oct 23, 2025
| return op.Floor(op.Abs(self)) * op.Sign(self) | ||
|
|
||
|
|
||
| @torch_op("math::trunc", trace_only=True) |
There was a problem hiding this comment.
Possible to use a single cast to do this?
There was a problem hiding this comment.
Sorry I don't understand.
There was a problem hiding this comment.
A single cast to INT64 should do the truncation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pytorch/pytorch#166110