Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 18, 2025

Show progress bar with tqdm when verbose is True.

image

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds an optional verbose flag to save_model_with_external_data to display progress via tqdm when available.

  • Extends function signature with verbose parameter (default False).
  • Implements conditional tqdm progress bar callback.
  • Introduces dynamic import/tqdm detection logic.

justinchuby and others added 3 commits October 18, 2025 09:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.43%. Comparing base (80f28c9) to head (3fd2986).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/_framework_apis/torch_2_5.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
+ Coverage   70.32%   70.43%   +0.10%     
==========================================
  Files         222      224       +2     
  Lines       26438    26585     +147     
  Branches     2632     2639       +7     
==========================================
+ Hits        18593    18724     +131     
- Misses       6926     6940      +14     
- Partials      919      921       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby changed the title Add a verbose model to torch api for external data Add a verbose mode to torch api for external data save Oct 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant