Skip to content

Conversation

@justinchuby
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the should_fold parameter to the optimize_ir() function, allowing users to provide custom folding logic during optimization. The change adds a new optional parameter that gets passed through to the constant folding pass.

  • Adds should_fold parameter to optimize_ir() function signature
  • Updates function documentation to describe the new parameter
  • Passes the parameter through to the constant folding optimization pass

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.94%. Comparing base (88b03d8) to head (01e88aa).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   69.93%   69.94%           
=======================================
  Files         223      223           
  Lines       26320    26321    +1     
  Branches     2604     2604           
=======================================
+ Hits        18408    18409    +1     
  Misses       7001     7001           
  Partials      911      911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby enabled auto-merge (squash) October 1, 2025 01:07
@justinchuby justinchuby merged commit 929a7f2 into main Oct 1, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Oct 1, 2025
@justinchuby justinchuby deleted the justinchu/should-fold branch October 1, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants