Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 24, 2025

Record names of contributing values in the constant folding pass to the newly created output as metadata, so that downstream users like Olive can use the info for further manipulations.

This is useful for Olive to identify transposed lora weights in the graph.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.05%. Comparing base (dddf0c2) to head (6fc4f73).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/optimizer/_constant_folding.py 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage   70.04%   70.05%           
=======================================
  Files         223      223           
  Lines       26215    26231   +16     
  Branches     2583     2587    +4     
=======================================
+ Hits        18363    18375   +12     
- Misses       6946     6948    +2     
- Partials      906      908    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added this to the 0.5.3 milestone Sep 29, 2025
@justinchuby justinchuby merged commit 94fb24f into main Sep 30, 2025
31 of 32 checks passed
@justinchuby justinchuby deleted the justinchu/folded-from branch September 30, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants