-
Notifications
You must be signed in to change notification settings - Fork 88
Record names of contributing values in the constant folding pass #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
=======================================
Coverage 70.04% 70.05%
=======================================
Files 223 223
Lines 26215 26231 +16
Branches 2583 2587 +4
=======================================
+ Hits 18363 18375 +12
- Misses 6946 6948 +2
- Partials 906 908 +2 ☔ View full report in Codecov by Sentry. |
xiaoyu-work
approved these changes
Sep 25, 2025
gramalingam
reviewed
Sep 26, 2025
gramalingam
approved these changes
Sep 26, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Sep 29, 2025
xiaoyu-work
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record names of contributing values in the constant folding pass to the newly created output as metadata, so that downstream users like Olive can use the info for further manipulations.
This is useful for Olive to identify transposed lora weights in the graph.