-
Couldn't load subscription status.
- Fork 87
[torchlib] Migrate torchvision implementations #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
- Coverage 70.09% 70.07% -0.02%
==========================================
Files 220 222 +2
Lines 26086 26204 +118
Branches 2575 2581 +6
==========================================
+ Hits 18285 18363 +78
- Misses 6904 6941 +37
- Partials 897 900 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates torchvision implementations by adding support for roi_align and roi_pool operations to the torch_lib vision module. The changes enable ONNX export compatibility for these computer vision operations commonly used in object detection models.
- Adds
torchvision::roi_alignimplementation with proper coordinate transformation and sampling ratio handling - Adds
torchvision::roi_poolimplementation using ONNX MaxRoiPool operator - Updates existing
torchvision::nmsoperation to be trace-only
|
Where do we migrate this from? Was there a test we can move to here as well? |
|
Adapted from https://github.com/pytorch/vision/blob/main/torchvision/ops/_register_onnx_ops.py. There are some tests we can move over too |
Adapted from https://github.com/pytorch/vision/blob/main/torchvision/ops/_register_onnx_ops.py