Skip to content

Conversation

@xadupre
Copy link
Member

@xadupre xadupre commented Jul 3, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.25%. Comparing base (3f2f7d3) to head (ae1a0d6).

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   69.23%   69.25%   +0.02%     
==========================================
  Files         210      210              
  Lines       25389    25381       -8     
  Branches     2546     2546              
==========================================
+ Hits        17577    17578       +1     
+ Misses       6939     6929      -10     
- Partials      873      874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code references on torchscript symbolic function implementation. Could you explain why the op could work on this way? And could you update the code, because g does not make any sense.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jul 3, 2025
@justinchuby justinchuby added this to the 0.4 milestone Jul 22, 2025
@justinchuby justinchuby assigned justinchuby and unassigned xadupre Jul 24, 2025
@justinchuby justinchuby changed the base branch from main to xadupre/split July 30, 2025 22:23
@justinchuby justinchuby merged commit d905b2a into microsoft:xadupre/split Jul 30, 2025
11 of 32 checks passed
@justinchuby
Copy link
Collaborator

Moving to a branch in the main repo for easier update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

3 participants