-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torchlib] Fix _log_softmax #1789
Conversation
Specify the squeeze axis explicitly to improve compatibility with ORT: microsoft/onnxruntime#21661
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
- Coverage 75.04% 75.02% -0.03%
==========================================
Files 245 245
Lines 26512 26518 +6
Branches 4834 4836 +2
==========================================
- Hits 19897 19895 -2
- Misses 5683 5688 +5
- Partials 932 935 +3 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 3h 26m 17s ⏱️ + 1m 47s For more details on these failures, see this check. Results for commit daeb3b3. ± Comparison against base commit cf5ddd9. This pull request removes 2183 tests.
♻️ This comment has been updated with latest results. |
Fix _log_softmax by moving the IsScalar call to the top so it can be eagerly evaluated.
Also specify the squeeze axis explicitly to improve compatibility with ORT: microsoft/onnxruntime#21661
This should fix a runtime error in XGLMForCausalLM