Add verbose support in single-output pattern-matcher #1555
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 77.56% 77.51% -0.05%
==========================================
Files 214 214
Lines 23186 23235 +49
Branches 3975 3990 +15
==========================================
+ Hits 17984 18011 +27
- Misses 4433 4457 +24
+ Partials 769 767 -2 ☔ View full report in Codecov by Sentry. |
Test Results 29 files ± 0 29 suites ±0 3h 10m 39s ⏱️ + 4m 29s For more details on these failures, see this check. Results for commit 0308f09. ± Comparison against base commit 69ae7f4. This pull request removes 2144 tests.♻️ This comment has been updated with latest results. |
| @classmethod | ||
| def FAIL(cls): | ||
| return cls(False) | ||
| def fail(self, reason: str = "") -> MatchResult: |
There was a problem hiding this comment.
Is there a way to include source/pass information too, or is that handle by a higher level entity?
| if subgraph replacement happens. But subsequent DCE will remove the constant | ||
| node if it is not used elsewhere. | ||
| """ | ||
| value = _ir_utils.propagate_const_value(value) |
There was a problem hiding this comment.
I would add a comment to remove these two lines when we sort this out
There was a problem hiding this comment.
Not sure I understand. It serves as documentation, in case a reader starts wondering about this. If we change this design, then we would need to change both the code and documentation.
There was a problem hiding this comment.
I mean value = _ir_utils.propagate_const_value(value) is temporary and we should remove _ir_utils usage when ready
Next step in unifying the two pattern-matchers: