Add 'aten_upsample_bilinear2d_vec' for unet #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 78.83% 78.75% -0.08%
==========================================
Files 118 118
Lines 15645 15658 +13
Branches 2476 2479 +3
==========================================
- Hits 12333 12332 -1
- Misses 2904 2919 +15
+ Partials 408 407 -1 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 2h 45m 42s ⏱️ + 1h 3m 30s For more details on these failures, see this check. Results for commit 7215c9f. ± Comparison against base commit 7bb78bc. This pull request removes 23 and adds 23 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
justinchuby
reviewed
Jan 12, 2024
justinchuby
approved these changes
Jan 12, 2024
BowenBao
commented
Jan 12, 2024
| @@ -2306,11 +2306,23 @@ def aten_upsample_bilinear2d( | |||
| result = _aten_upsample_bilinear2d_output_size(self, output_size) | |||
| else: | |||
| assert scales_h is not None | |||
| assert scales_h == scales_w | |||
| assert scales_h == scales_w, f"scale_h({scales_h}) != scale_w({scales_w})" | |||
There was a problem hiding this comment.
I don't understand why there is this restriction.
There was a problem hiding this comment.
@xiaowuhu could you help?
justinchuby
reviewed
Jan 12, 2024
| @@ -2122,6 +2134,12 @@ def _where_input_wrangler( | |||
| input_wrangler=_upsample_bilinear2d_input_wrangler, | |||
| trace_only=True, | |||
| ), | |||
| TorchLibOpInfo( | |||
| "nn.functional.upsample_bilinear2d", | |||
There was a problem hiding this comment.
Should probably test against the .vec overload?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.