-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'aten_upsample_bilinear2d_vec' for unet #1249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 78.83% 78.75% -0.08%
==========================================
Files 118 118
Lines 15645 15658 +13
Branches 2476 2479 +3
==========================================
- Hits 12333 12332 -1
- Misses 2904 2919 +15
+ Partials 408 407 -1 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 2h 45m 42s ⏱️ + 1h 3m 30s For more details on these failures, see this check. Results for commit 7215c9f. ± Comparison against base commit 7bb78bc. This pull request removes 23 and adds 23 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@@ -2306,11 +2306,23 @@ def aten_upsample_bilinear2d( | |||
result = _aten_upsample_bilinear2d_output_size(self, output_size) | |||
else: | |||
assert scales_h is not None | |||
assert scales_h == scales_w | |||
assert scales_h == scales_w, f"scale_h({scales_h}) != scale_w({scales_w})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why there is this restriction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiaowuhu could you help?
@@ -2122,6 +2134,12 @@ def _where_input_wrangler( | |||
input_wrangler=_upsample_bilinear2d_input_wrangler, | |||
trace_only=True, | |||
), | |||
TorchLibOpInfo( | |||
"nn.functional.upsample_bilinear2d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably test against the .vec overload?
No description provided.