-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add op(upsample nearst1/2/3d) | feat(torchlib) #1246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 78.88% 79.00% +0.11%
==========================================
Files 119 119
Lines 15715 15762 +47
Branches 2482 2486 +4
==========================================
+ Hits 12397 12452 +55
+ Misses 2910 2902 -8
Partials 408 408 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 1h 42m 7s ⏱️ + 7m 39s For more details on these failures, see this check. Results for commit 11101c9. ± Comparison against base commit 670dbfa. This pull request removes 27 and adds 31 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
For some reason it seems size became a string. Was the input order correct in the test cases? |
We may modify onnxscript\evaluator.py:484 to print out inputs as well when there is an error |
…microsoft/onnxscript into xiaowu/addOp(upsample-nearst1d)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments addressed. Thanks!
This function works well in FullGraph mode, but failed in Eager mode. Something wrong?