Add op(upsample nearst1/2/3d) | feat(torchlib) #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 78.88% 79.00% +0.11%
==========================================
Files 119 119
Lines 15715 15762 +47
Branches 2482 2486 +4
==========================================
+ Hits 12397 12452 +55
+ Misses 2910 2902 -8
Partials 408 408 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 1h 42m 7s ⏱️ + 7m 39s For more details on these failures, see this check. Results for commit 11101c9. ± Comparison against base commit 670dbfa. This pull request removes 27 and adds 31 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For some reason it seems size became a string. Was the input order correct in the test cases? |
|
We may modify onnxscript\evaluator.py:484 to print out inputs as well when there is an error |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Jan 18, 2024
justinchuby
added
the
topic: torch_lib
justinchuby
changed the title
…microsoft/onnxscript into xiaowu/addOp(upsample-nearst1d)
xiaowuhu
changed the title
8 tasks
justinchuby
reviewed
Jan 29, 2024
justinchuby
reviewed
Jan 29, 2024
justinchuby
approved these changes
Feb 4, 2024
justinchuby
reviewed
Feb 4, 2024
justinchuby
reviewed
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function works well in FullGraph mode, but failed in Eager mode. Something wrong?