Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for _fft_c2r function. #1198

Merged
merged 17 commits into from
Dec 1, 2023
Merged

Conversation

fatcat-z
Copy link
Contributor

@fatcat-z fatcat-z commented Dec 1, 2023

Create custom tests of _fft_c2r() to help evaluating the fix to it in torch_lib. Fail them because the function doesn't work well yet.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e22077) 78.68% compared to head (f52ff11) 78.23%.

❗ Current head f52ff11 differs from pull request most recent head 3d11fbf. Consider uploading reports for the commit 3d11fbf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   78.68%   78.23%   -0.46%     
==========================================
  Files         118      118              
  Lines       15436    15443       +7     
  Branches     2424     2426       +2     
==========================================
- Hits        12146    12082      -64     
- Misses       2892     2966      +74     
+ Partials      398      395       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

Thanks! I think I saw PyTorch errors with the test examples. Was there any test cases that need to be adjusted?

@justinchuby justinchuby added topic: torch_lib Related to the torch/aten function lib in development hold on merging Don't merge yet labels Dec 1, 2023
@fatcat-z fatcat-z merged commit c4b91e8 into microsoft:main Dec 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold on merging Don't merge yet topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants