Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add castlike to var | fix(torchlib) #1195

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add castlike to var | fix(torchlib) #1195

merged 1 commit into from
Nov 30, 2023

Conversation

justinchuby
Copy link
Collaborator

Follow up of #1186 to fix the dtype mismatch in Sub in the var/var.correction implementation.

@justinchuby justinchuby added topic: torch_lib Related to the torch/aten function lib in development merge at lgtm Reviewers can merge when they approve labels Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e35a179) 78.64% compared to head (85575dc) 78.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   78.64%   78.66%   +0.01%     
==========================================
  Files         118      118              
  Lines       15441    15441              
  Branches     2424     2424              
==========================================
+ Hits        12144    12146       +2     
+ Misses       2899     2897       -2     
  Partials      398      398              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

         24 files  ±         0         24 suites  ±0   1h 51m 47s ⏱️ - 2m 1s
  11 254 tests ±         0    8 371 ✔️  -        7      2 876 💤 +         3  7 +  4 
272 407 runs  +16 636  61 346 ✔️ +4 106  211 054 💤 +12 544  7  - 14 

For more details on these failures, see this check.

Results for commit 85575dc. ± Comparison against base commit e35a179.

This pull request skips 3 tests.
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__var_correction_cpu_float16
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__var_correction_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__var_dim_cpu_float16

@titaiwangms
Copy link
Contributor

Also do this in this PR? #1186 (comment)

@justinchuby
Copy link
Collaborator Author

Also do this in this PR? #1186 (comment)

It would be dependent on merging #1192

@justinchuby justinchuby merged commit 5a8f4e3 into main Nov 30, 2023
35 of 37 checks passed
@justinchuby justinchuby deleted the justinchu/fix-var branch November 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants