Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onnxruntime team from CODEOWNERS #8954

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

garymm
Copy link
Contributor

@garymm garymm commented Sep 3, 2021

There are currently 98 members in the team. Requesting review from
all of them for every PR is too noisy. Individuals can subscribe to the
repo if they want to receive notifications for every PR.

There are currently 98 members in the team. Requesting review from
all of them for every PR is too noisy.
@garymm garymm requested a review from pranavsharma September 3, 2021 00:14
@garymm garymm requested a review from a team as a code owner September 3, 2021 00:14
pranavsharma
pranavsharma previously approved these changes Sep 3, 2021
@pranavsharma
Copy link
Contributor

@garymm - will github still require a review before merging PRs if the files included in the PRs don't match the whitelisted paths mentioned in the CODEOWNERS file? If not, we can't remove the onnxruntime line.
Like other repos, we've the following configured for the master branch.

image

@pranavsharma pranavsharma dismissed their stale review September 3, 2021 01:51

Follow up question.

@garymm
Copy link
Contributor Author

garymm commented Sep 3, 2021

@garymm - will github still require a review before merging PRs if the files included in the PRs don't match the whitelisted paths mentioned in the CODEOWNERS file?

I believe you can configure GH to require reviews for all PRs by selecting "Require pull request reviews before merging" in "Branch protection rules".

@pranavsharma I'll wait for your approval before merging this.

@pranavsharma
Copy link
Contributor

@garymm - will github still require a review before merging PRs if the files included in the PRs don't match the whitelisted paths mentioned in the CODEOWNERS file?

I believe you can configure GH to require reviews for all PRs by selecting "Require pull request reviews before merging" in "Branch protection rules".

This is already enabled.

@natke natke self-requested a review September 3, 2021 17:57
@garymm garymm merged commit e357022 into microsoft:master Sep 9, 2021
@garymm garymm deleted the codeowners branch September 9, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants