Disable one more test when contrib ops are disabled. #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywu-msft
approved these changes
Apr 7, 2019
|
Maybe I know. There was a known issue in onnx_test_runner. It was introduced in Pranav's PR #639, that it may access uninitialized memory when retrieving test config. It because OnnxTestCase::ParseConfig() may forget to initialize some config variable, especially post_processing_. If it is true, value will be cut into [0-255]. |
jignparm
approved these changes
Apr 7, 2019
|
I don't think this PR is good. Because, you just exclude one test failure you have seen, but you may get more random test failures in future runs. |
|
As you said it'll get fixed in the master branch due to PR 751. |
|
If you have more changes in rel-0.3.1, you may hit this issue again. |
|
rel-0.3.1 is sealed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more test failed as per https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=79109. Not sure why this didn't fail earlier.