Skip to content

Conversation

duli2012
Copy link
Contributor

@duli2012 duli2012 commented Nov 12, 2020

Description: Describe your changes.
Make bilinear and trilinear mode of Resize parallel

Motivation and Context

  • Why is this change required? What problem does it solve?
    This change makes the resize op 3 times faster for a product model.

Credit to @tlh20

@duli2012 duli2012 requested a review from a team as a code owner November 12, 2020 21:37
@duli2012 duli2012 assigned duli2012, tlh20, pranavsharma and snnn and unassigned duli2012 Nov 12, 2020
@duli2012
Copy link
Contributor Author

Currently, it's using ThreadPool::TrySimpleParallelFor API. We'd like to use ThreadPool::TryParallelFor which is more robust and effcient. However, the latter has unaddressed issues related Eigan cost model, which we'll revisit later.

Copy link
Contributor

@tlh20 tlh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor formatting glitches. Only substantive comment is if we need to fall back to sequential execution on any cases.

@duli2012 duli2012 requested a review from tlh20 November 17, 2020 16:00
@duli2012 duli2012 merged commit 3b5ba1c into master Nov 17, 2020
@duli2012 duli2012 deleted the duli/resize branch November 17, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants