Solve name conflict in TensorRT engine caching #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenlix
commented
Sep 11, 2020
stevenlix
commented
- Fix hash conflict issue in engine cache naming
- Add more verbose log in engine caching
- Move engine/context release to right location
- Update onnx-tensorrt parser to include latest fix
jywu-msft
reviewed
Sep 11, 2020
| for (auto& i : vec) { | ||
| ret ^= std::hash<uint32_t>()(i); | ||
| ret ^= i + 0x9e3779b9 + (ret << 6) + (ret >> 2); |
There was a problem hiding this comment.
any comments on how this hash function was chosen?
There was a problem hiding this comment.
The constant number and shifting are used to increase the distance of consecutive hash values and reduce hash conflicts.
Here is a good explanation, https://stackoverflow.com/questions/4948780/magic-number-in-boosthash-combine.
jywu-msft
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.