Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS and minor docstring fix #5002

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

thiagocrepaldi
Copy link
Contributor

Previous CODEOWNERS was encompassing more files than just training files
Polynomial optimizer config is missing part of its docstring

CODEOWNERS Outdated Show resolved Hide resolved
spandantiwari
spandantiwari previously approved these changes Sep 1, 2020
spandantiwari
spandantiwari previously approved these changes Sep 1, 2020
Copy link

@spandantiwari spandantiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if some one on ORT core side can also review it.

tianleiwu
tianleiwu previously approved these changes Sep 2, 2020
@thiagocrepaldi thiagocrepaldi force-pushed the thiagofc/new_frontend/fix_codeowners branch from aa264cb to 2f2d4cf Compare September 2, 2020 23:31
BowenBao
BowenBao previously approved these changes Sep 2, 2020
jywu-msft
jywu-msft previously approved these changes Sep 3, 2020
Previous CODEOWNERS was encompassing more files than just training files
Polynomial optimizer config is missing part of its docstring
@thiagocrepaldi thiagocrepaldi dismissed stale reviews from jywu-msft and BowenBao via 30a23d0 September 3, 2020 16:10
@thiagocrepaldi thiagocrepaldi force-pushed the thiagofc/new_frontend/fix_codeowners branch from 2f2d4cf to 30a23d0 Compare September 3, 2020 16:10
@thiagocrepaldi thiagocrepaldi merged commit 9d1bdef into master Sep 3, 2020
@thiagocrepaldi thiagocrepaldi deleted the thiagofc/new_frontend/fix_codeowners branch September 3, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants