-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS and minor docstring fix #5002
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spandantiwari
previously approved these changes
Sep 1, 2020
thiagocrepaldi
force-pushed
the
thiagofc/new_frontend/fix_codeowners
branch
from
September 1, 2020 21:36
ba6d414
to
aa264cb
Compare
spandantiwari
previously approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's see if some one on ORT core side can also review it.
tianleiwu
previously approved these changes
Sep 2, 2020
thiagocrepaldi
dismissed stale reviews from tianleiwu and spandantiwari
via
September 2, 2020 23:31
2f2d4cf
thiagocrepaldi
force-pushed
the
thiagofc/new_frontend/fix_codeowners
branch
from
September 2, 2020 23:31
aa264cb
to
2f2d4cf
Compare
BowenBao
previously approved these changes
Sep 2, 2020
jywu-msft
previously approved these changes
Sep 3, 2020
Previous CODEOWNERS was encompassing more files than just training files Polynomial optimizer config is missing part of its docstring
thiagocrepaldi
dismissed stale reviews from jywu-msft and BowenBao
via
September 3, 2020 16:10
30a23d0
thiagocrepaldi
force-pushed
the
thiagofc/new_frontend/fix_codeowners
branch
from
September 3, 2020 16:10
2f2d4cf
to
30a23d0
Compare
BowenBao
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous CODEOWNERS was encompassing more files than just training files
Polynomial optimizer config is missing part of its docstring