Refactor scatter/gather ops to use the new cost based threadpool abstractions. #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've one more change coming up in mlas/lib/threading.cpp file. Prefer to separate this from mlas change for easy debugging in case there are any perf regressions. |
skottmckay
reviewed
May 1, 2020
skottmckay
reviewed
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Refactor scatter/gather ops to use the new cost based threadpool abstractions. Also removed unnecessary usages of openmp. Tested on all models in the perf dashboard. For non-openmp builds it seemed to perform better than the master for most models. The openmp builds should've no impact.
Motivation and Context
Consistent usage of threapool APIs across all ops that account for openmp and Eigen in one place.