Validate the axis of Gather/Slice - #31711
Open
shiyi (shiyi9801) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Scott McKay (@skottmckay) This is a fix for potential vulnerability, PTAL, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate the axis of Gather/Slice consumers against the input rank in
GatherSliceToSplitFusion()before it is used to index the shape's dimensions.GetGatherAxisandGetSliceAxispreviously only normalized a negative axis (axis += rank) and returned it unchecked.ApplyImpl()then didshape->dim(static_cast<int>(axis))without any bounds check, so an out-of-range axis can lead to an out-of-bounds read of theTensorShapeProto'sdim_.