[WebNN EP] Add output rank validation - #31708
Open
Wanming Lin (Honry) wants to merge 1 commit into
Open
Conversation
Mirror the existing input rank check by validating each node's output rank against the WebNN opSupportLimits rankRange. - Rename IsInputRankSupported -> IsRankSupportedByWebNNOp and skip the check when the op / parameter / rankRange is undefined in MLOpSupportLimits to make it compatible with older browers. - Add IsOutputRankSupportedByOp for the common single-"output" case. - Add output rank checks to multi-output ops (gru, lstm, split) using their specific output parameter names. - Skip decomposed ops (their type checks loop over sub-ops whose ranks differ from the final output).
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the existing input rank check by validating each node's output rank against the WebNN
opSupportLimits'srankRange.IsInputRankSupported->IsRankSupportedByWebNNOpand skip the check when the op / parameter / rankRange is undefined inMLOpSupportLimitsto make it compatible with older browers.IsOutputRankSupportedByOpfor the common single-"output" case.