Fix out-of-bounds read in CropBase: validate scale attribute length#28399
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/onnxruntime/sessions/acf4446a-1506-4a7b-a821-4ab185d0aa06 Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
tianleiwu
May 7, 2026 17:54
View session
tianleiwu
marked this pull request as ready for review
May 7, 2026 22:06
tianleiwu
approved these changes
May 12, 2026
hariharans29
previously approved these changes
May 12, 2026
tianleiwu
enabled auto-merge (squash)
May 12, 2026 20:03
hariharans29
approved these changes
May 13, 2026
This was referenced Jun 20, 2026
This was referenced Jun 22, 2026
deps(nuget): Bump the microsoft-packages group with 1 update
Ellerbach/azure-ai-search-simulator#171
Merged
Open
This was referenced Jul 1, 2026
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CropBase::ValidateInputguardedscale_[0]/scale_[1]access with!scale_.empty()but never enforcedscale_.size() == 2. A malformed model with a wrong-lengthscaleattribute (e.g. 1 element) causes an out-of-bounds read in both validation and compute paths.Changes:
contrib_ops/cpu/crop.h— inside the!scale_.empty()branch, returnINVALID_ARGUMENTearly ifscale_.size() != 2with a descriptive message before any indexing occurs.Computeis protected transitively since it callsValidateInputfirst.test/contrib_ops/crop_op_test.cc— addedCrop_Invalid_Scale_Sizetest: passes a 1-elementscaleattribute and asserts the expected error is returned.Motivation and Context
scale_is a user-supplied attribute read directly from the model. Without length validation a malformed model can trigger undefined behavior (out-of-bounds vector read) in both the CPU and CUDACropkernels (CUDA inheritsCropBase).