Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 29, 2025

Description

PR #26873 moved enable_pix_capture from WebGpuContextConfig to WebGpuExecutionProviderConfig but didn't update webgpu_provider_factory.cc to parse the config option into the correct struct.

Changes:

  • Move PIX capture config parsing from ParseWebGpuContextConfig() to ParseEpConfig()
  • Update logging to use the correct config struct (webgpu_ep_config.enable_pix_capture)

Motivation and Context

Build was failing with:

'enable_pix_capture': is not a member of 'onnxruntime::webgpu::WebGpuContextConfig'

This completes the refactoring in #26873 which makes the PIX frame generator per-session instead of per-WebGpuContext.

Original prompt

Please help me to fix the build break for #26873.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

eserscor and others added 2 commits December 29, 2025 12:45
### Description
[Change 26634](#26634)
added the qnn variant to the audit wheel process, but the qnn libraries
do not pass audit repair due to a dependency on libc++. Continue to not
audit qnn on x86_64 and rely on the correct dependencies being available for the
user.


### Motivation and Context
Fixes build packaging pipeline
Copilot AI and others added 2 commits December 29, 2025 21:47
Co-authored-by: fs-eire <7679871+fs-eire@users.noreply.github.com>
…puExecutionProviderConfig

Co-authored-by: fs-eire <7679871+fs-eire@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build break issue for task #26873 Fix build break for #26873: Move enable_pix_capture parsing to WebGpuExecutionProviderConfig Dec 29, 2025
Copilot AI requested a review from fs-eire December 29, 2025 21:52
@fs-eire
Copy link
Contributor

fs-eire commented Dec 29, 2025

@copilot Please make this PR targetting branch fs-eire/make-pix-per-session instead of targetting main so that it fixes the build error of PR 26873

Copy link
Contributor Author

Copilot AI commented Dec 29, 2025

@copilot Please make this PR targetting branch fs-eire/make-pix-per-session instead of targetting main so that it fixes the build error of PR 26873

I'm unable to change the PR's target branch as I don't have the ability to modify PR settings. You or another maintainer will need to change the base branch from main to fs-eire/make-pix-per-session through the GitHub UI (click "Edit" next to the PR title, then change the base branch).

@fs-eire fs-eire changed the base branch from main to fs-eire/make-pix-per-session December 29, 2025 22:00
@fs-eire fs-eire marked this pull request as ready for review December 29, 2025 22:01
@fs-eire fs-eire merged commit 50afc5d into fs-eire/make-pix-per-session Dec 29, 2025
64 of 65 checks passed
@fs-eire fs-eire deleted the copilot/fix-build-break-26873 branch December 29, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants