Maxpool_With_Mask #267
Merged
Maxpool_With_Mask #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time into duli/maxpool_with_mask
snnn
approved these changes
Dec 30, 2018
|
How do we keep these operators from increasing the winml image size? Does this have an application beyond your custom model? I would have thought this is why we have external custom operators. |
|
@tracysh I shared the same concern with you during the discussion for PR229(https://github.com/Microsoft/onnxruntime/pull/229/). At the end, the decision was to add a compilation flag to decide whether the build include contrib ops or not. By external custom op, do you mean wrap custom op in dll? We did consider it, but it's not ready yet. Anyway, the current bar for checking in a custom op is relatively low. But if we change our strategy in the future, I have no problem to undo these check-ins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom op that that does maxpool on variable length of input data. For a model we're working on, this op substantially reduces both graph complexity and latency.