Fix Build Error when tensor dumping is enabled #25414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunal-vaishnavi
approved these changes
Jul 16, 2025
nenad1002
approved these changes
Jul 16, 2025
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
### Description Fix cuda build error when DEBUG_GENERATION is defined. ### Motivation and Context In microsoft#24821, a dumping API was removed: `void Print(const char* name, int index, bool end_line)` But related code is not updated. In MatMulNBits, there is a recent change to add bfloat16 support, but the tensor dumper only support BFloat16 but not __nv_bfloat16. This PR adds functions to support __nv_bfloat16 in cuda tensor dumper.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description Fix cuda build error when DEBUG_GENERATION is defined. ### Motivation and Context In microsoft#24821, a dumping API was removed: `void Print(const char* name, int index, bool end_line)` But related code is not updated. In MatMulNBits, there is a recent change to add bfloat16 support, but the tensor dumper only support BFloat16 but not __nv_bfloat16. This PR adds functions to support __nv_bfloat16 in cuda tensor dumper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cuda build error when DEBUG_GENERATION is defined.
Motivation and Context
In #24821, a dumping API was removed:
void Print(const char* name, int index, bool end_line)But related code is not updated.
In MatMulNBits, there is a recent change to add bfloat16 support, but the tensor dumper only support BFloat16 but not __nv_bfloat16. This PR adds functions to support __nv_bfloat16 in cuda tensor dumper.