Enable VCPKG in CI build #23426

snnn · 2025-01-18T22:19:28Z

Description

Enable VCPKG flag in Windows CPU CI build pipelines.
Increased the min supported cmake version from 3.26 to 3.28. Because of it, drop the support for the old way of finding python by "find_package(PythonLibs)". Therefore, in build.py we no longer set "PYTHON_EXECUTABLE" cmake var when doing cmake configure.
Added "xnnpack-ep" as a feature for ORT's vcpkg config.
Added asset cache support for ORT's vcpkg build
Added VCPKG triplet files for Android build.
Set VCPKG triplet to "universal2-osx" if CMAKE_OSX_ARCHITECTURES was found in cmake extra defines.
Removed a small piece of code in build.py, which was for support CUDA version < 11.8.
Fixed an issue that CMAKE_OSX_ARCHITECTURES sometimes got specified twice when build.py invoked cmake.
Added more model tests to Android build. After this change, we will test all ONNX versions instead of just the latest one.
Fixed issues that are related to build.py's "--build_nuget" parameter. Also, enable the flag in most Windows CPU CI build jobs.
Removed a restriction in build.py that disallowed cross-compiling Windows ARM64 nuget package on Windows x86.

Motivation and Context

tools/ci_build/build.py

github-actions

You can commit the suggested changes from lintrunner.

tools/ci_build/build.py

cmake/vcpkg-triplets/gen.py

tools/ci_build/build.py

### Description 1. Enable VCPKG flag in Windows CPU CI build pipelines. 2. Increased the min supported cmake version from 3.26 to 3.28. Because of it, drop the support for the old way of finding python by "find_package(PythonLibs)". Therefore, in build.py we no longer set "PYTHON_EXECUTABLE" cmake var when doing cmake configure. 3. Added "xnnpack-ep" as a feature for ORT's vcpkg config. 4. Added asset cache support for ORT's vcpkg build 5. Added VCPKG triplet files for Android build. 6. Set VCPKG triplet to "universal2-osx" if CMAKE_OSX_ARCHITECTURES was found in cmake extra defines. 7. Removed a small piece of code in build.py, which was for support CUDA version < 11.8. 8. Fixed an issue that CMAKE_OSX_ARCHITECTURES sometimes got specified twice when build.py invoked cmake. 9. Added more model tests to Android build. After this change, we will test all ONNX versions instead of just the latest one. 10. Fixed issues that are related to build.py's "--build_nuget" parameter. Also, enable the flag in most Windows CPU CI build jobs. 11. Removed a restriction in build.py that disallowed cross-compiling Windows ARM64 nuget package on Windows x86. ### Motivation and Context Adopt vcpkg.

### Description This PR is to update the win-ort-main branch to the tip main branch as of 2025-02-11. ### PR List 74c778e [WebNN EP] Automatically move input CPU tensors to ml-tensor (#23073) 3775057 use correct total length to fix static kv_cache performance (#23615) 3901e96 remove --use_vcpkg flag for Python-CUDA-Packaging-Pipeline (#23631) c610df5 Add python_requires to package metadata (#23604) 2d27d68 [QNN EP] Add QNN EP to ARM64X build targets (#23635) e666503 [webgpu] no longer need pass-in gpu adapter for custom context (#23593) af679a0 Fix logic for selecting alternate name for blob (#23617) e206950 [ARM CPU] Add fp16 mlas kernels for exp, tanh, softmax, logsoftmax, softcap (#23597) 9ba5619 Update pybind and json to the latest (#23589) c54736c Migrate iOS release pipeline to 1 ES (#23606) 3981326 Increase timeout for Windows TensorRT CI (#23625) 0274b7b fix on trtCudaVersion (#23616) 740e9ab update run CI script (#23621) 5ef1832 [WebGPU] Support PIX Capture for WebGPU EP (#23192) 0114551 Fix for C4267 warning (#23610) 002916a Validate the context_file_path before EP compile graphs (#23611) 0887e36 [webgpu] Use pushErrorScope()/popErrorScope() once for an inference run (#23438) 65008cb Auto-generated baselines by 1ES Pipeline Templates (#23603) 09e5724 [CUDA] Fix beam search of num_beams > 32 (#23599) 82840f6 Implement Flash Attention 2 for webgpu EP (#23576) a6ea57b OpenVINO EP Weights Sharing Feature (#23553) 2c2ff4a [CUDA] Fix BeamSearchTest.DummyT5WithSequenceInputIds test failure in Windows (#23596) d981b15 [webgpu/js] Optimize resize webgpu op & fix precision issues (#23591) 328a13c Enable VCPKG in more pipelines (#23590) 6728d60 [TensorRT EP] support TensorRT 10.8-GA (#23592) d1fb58b Quantization tool: Allow user to override calibrator's session EP (#23559) 649ced4 Enable user loading model with external data from memory buffer (#23557) 544bdd6 Fix ConvTranspose for certain attribute combinations (#23488) 8f6ddf3 Delete extra cgmanifest entries and files (#23583) 5f6a315 Enable VCPKG in CI build (#23426) e1e3f62 Bump lintrunner from 0.12.5 to 0.12.7 (#23326) cd8775f Fix Node JS Samples (#23581) 6b4f9c4 [WebGPU EP] Batch Norm Implementation (#23525) 1fce51b Fix all instances of 4244 and 4267 warnings in OV EP code (#23567) c29ca1c Update QNN default version to 2.31 (#23573) 2fc75a4 [mobile] Add Android BrowserStack test project back (#23551) 9e18b6a [CUDA] Update nvcc flags (#23572) b47e1e6 [QNN EP] Make offloading graph input/output quantization (to CPU) the default (#23368) 75a9b40 [ROCm] Update CI to use rocm 6.3.2 (#23577) 26ff2b6 Bump ruff from 0.9.3 to 0.9.4 (#23563) b2560a7 Update react-native to 0.72 (#23509) faee912 [js] update JavaScript API to support QNN EP options (#23486) 816e8cb [EP Perf] Update env to ubuntu 22.04 (#23570) cddc271 Use Eigen in Round implementation (#23571) e8b0bdb Shape inference: ReduceMean dispatcher, quant_pre_process: skip_symbolic_shape bugfix (#23558) 267b493 delete the supported domain version upper bounds (#23237) bb7f961 remove log spam from cpuinfo (#23548) 169917b Use latest vcpkg commit in configuration, sync manifest with deps.txt (#23554) a9d4d08 Add of ReduceMax Gradient (#23501) 6bbf1bd [js/web] upgrade version of flatbuffers (#23545) 271c509 DP4AMatMul perf refinements (#23539) cb69c59 Add fusions for SigLIP and Conformer-Encoder (#23528) 61fae9b Remove "--enable_pybind" from webgpu pipeline (#23550) 0bb4ea6 Update BiasGelu fusion and related ops (#23518) 4dde74a Add more details to BrowserStack script failure (#23520) ead9d5c Set ANDROID_USE_LEGACY_TOOLCHAIN_FILE to false (#23544) 7e24088 Enable dlpack by default (#23110) dc2f7a9 Add overload of `TryParseStringWithClassicLocale()` that uses `std::from_chars()` (#23541) 5407c69 Fix the issue that the new generated EP context model not able to find external data (#23537) fbae88f [js/web] use the recommended workaround for Vite (#23531) d5338da Fix tensor external data info length parsing issue. (#23526) e3e4173 [ROCm EP] Fix transpose helper for gfx gridsize constraints (#23527) 80bc1d2 Enable Ep context with external data for CPU nodes (#23498) bf023ab [js/web] allow import .mjs/.wasm file (#23487) 655a23f [onnxruntime/build] Add new flag enable_generic_interface to build primary EPs by default (#23342) a770a8d Update RN to 0.71.19 (#23381) 1cf0ebd Delete Prefast workflow until the build failure is fixed (#23510) d2c5e24 Add of GlobalMaxPool Gradient (#23502) ded8730 Remove thrust::unary_function (#23506) 8db97a6 [webgpu] Bump version of Dawn to b9b4a370 (#23494) fdde2e2 Fix for gcc 13.3.1: Avoid creating a copy (#23500) 96ec1dd Bump ruff from 0.9.2 to 0.9.3 (#23496) 42f0c00 Adds the new System.Numerics.Tensors as an input/output type when using dotnet 8.0 and up. (#23261) 97c2bbe Fix shape infer of onnx GroupNorm (#23477) 1fc9c48 Enable coremltools for Linux build (#23481) 13348c5 [ARM CPU] hgemm optimized for gqa (#23107) c89a798 Enable opti on Microsoft.ML.OnnxRuntime with RelWithDebInfo config (#23463) d00ae32 Revert "[Mobile] Add BrowserStack Android MAUI Test (#23383)" (#23474) 8b1d3b3 Align AvgPool ceil_mode on last value to torch (#16752) 06fc73b [TRT EP Perf Tool] Add annotations import to python script to support annotations on Python 3.8 (#23466) ### Motivation and Context This update includes the change to add QNN EP to ARM64X build targets. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com> Co-authored-by: Ti-Tai Wang <titaiwang@microsoft.com> Co-authored-by: Caroline Zhu <wolfivyaura@gmail.com> Co-authored-by: Grégoire <gregoire.verdier@gmail.com> Co-authored-by: Jing Fang <126209182+fajin-corp@users.noreply.github.com> Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: Yateng Hong <yatengh@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch> Co-authored-by: Yulong Wang <7679871+fs-eire@users.noreply.github.com> Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com> Co-authored-by: Corentin Maravat <101636442+cocotdf@users.noreply.github.com> Co-authored-by: Jian Chen <cjian@microsoft.com> Co-authored-by: Karim Vadsariya <karim.vadsariya@microsoft.com> Co-authored-by: Lei Cao <jslhcl@gmail.com> Co-authored-by: Karim Vadsariya <kvadsariya@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hector Li <hecli@microsoft.com> Co-authored-by: Ted Themistokleous <107195283+TedThemistokleous@users.noreply.github.com> Co-authored-by: Ted Themistokleous <tedthemistokleous@amd.com> Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com> Co-authored-by: Takeshi Watanabe <take-cheeze@users.noreply.github.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Tianlei Wu <tlwu@microsoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com> Co-authored-by: Sushanth Rajasankar <44513542+sushraja-msft@users.noreply.github.com> Co-authored-by: PARK DongHa <luncliff@gmail.com> Co-authored-by: George Wu <jywu@microsoft.com> Co-authored-by: Xinpeng Dou <15529241576@163.com> Co-authored-by: Jambay Kinley <jambaykinley@microsoft.com> Co-authored-by: Yifan Li <109183385+yf711@users.noreply.github.com> Co-authored-by: Gavin Kinsey <98115505+ms-gavinkinsey@users.noreply.github.com> Co-authored-by: Prathik Rao <prathik.rao@gmail.com> Co-authored-by: Jon Campbell <jcampbell@cephable.com> Co-authored-by: Satya Kumar Jandhyala <satya.k.jandhyala@gmail.com> Co-authored-by: Joshua Lochner <admin@xenova.com> Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com> Co-authored-by: jatinwadhwa921 <jatin.wadhwa@intel.com> Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com> Co-authored-by: saurabh <saurabh1.kale@intel.com> Co-authored-by: TejalKhade28 <tejal.khade@intel.com> Co-authored-by: sfatimar <sahar.fatima@intel.com> Co-authored-by: Javier E. Martinez <javier.e.martinez@intel.com> Co-authored-by: Preetha Veeramalai <preetha.veeramalai@intel.com> Co-authored-by: Eric Crawford <eric.r.crawford@intel.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Jie Chen <jie.a.chen@intel.com> Co-authored-by: shaoboyan091 <shaoboyan@microsoft.com> Co-authored-by: David Hotham <david.hotham@microsoft.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: Enrico Galli <enrico.galli@intel.com>

The extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like: ``` CMake Error at cmake_install.cmake:47 (include): include could not find requested file: /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake ``` When running "make install" command after successfully building onnxruntime without vcpkg. The issue doesn't exist when vcpkg is enabled.

zwassall-gentuity · 2025-02-28T19:31:49Z

Should any/all of the patch files in "cmake/vcpkg-ports" be synchronized with the patch files in "cmake/patches"? I ask because I'm currently encountering an error building onnxruntime using clang-cl 19.1.1. The error is resolved by replacing https://github.com/microsoft/onnxruntime/blob/1be64f883190f058256948c8d254c61d1a724008/cmake/patches/protobuf/protobuf_cmake.patch with the newer https://github.com/microsoft/onnxruntime/blob/1be64f883190f058256948c8d254c61d1a724008/cmake/vcpkg-ports/protobuf/protobuf_cmake.patch. I don't know enough to say if there are additional patch files that should be synchronized as well, or if the synchronization should be one-way or bidirectional.

snnn · 2025-02-28T21:09:28Z

Thanks for bringing it up. Would you please create a PR for this?

### Description 1. Enable VCPKG flag in Windows CPU CI build pipelines. 2. Increased the min supported cmake version from 3.26 to 3.28. Because of it, drop the support for the old way of finding python by "find_package(PythonLibs)". Therefore, in build.py we no longer set "PYTHON_EXECUTABLE" cmake var when doing cmake configure. 3. Added "xnnpack-ep" as a feature for ORT's vcpkg config. 4. Added asset cache support for ORT's vcpkg build 5. Added VCPKG triplet files for Android build. 6. Set VCPKG triplet to "universal2-osx" if CMAKE_OSX_ARCHITECTURES was found in cmake extra defines. 7. Removed a small piece of code in build.py, which was for support CUDA version < 11.8. 8. Fixed an issue that CMAKE_OSX_ARCHITECTURES sometimes got specified twice when build.py invoked cmake. 9. Added more model tests to Android build. After this change, we will test all ONNX versions instead of just the latest one. 10. Fixed issues that are related to build.py's "--build_nuget" parameter. Also, enable the flag in most Windows CPU CI build jobs. 11. Removed a restriction in build.py that disallowed cross-compiling Windows ARM64 nuget package on Windows x86. ### Motivation and Context Adopt vcpkg.

The extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like: ``` CMake Error at cmake_install.cmake:47 (include): include could not find requested file: /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake ``` When running "make install" command after successfully building onnxruntime without vcpkg. The issue doesn't exist when vcpkg is enabled.

### Description 1. Enable VCPKG flag in Windows CPU CI build pipelines. 2. Increased the min supported cmake version from 3.26 to 3.28. Because of it, drop the support for the old way of finding python by "find_package(PythonLibs)". Therefore, in build.py we no longer set "PYTHON_EXECUTABLE" cmake var when doing cmake configure. 3. Added "xnnpack-ep" as a feature for ORT's vcpkg config. 4. Added asset cache support for ORT's vcpkg build 5. Added VCPKG triplet files for Android build. 6. Set VCPKG triplet to "universal2-osx" if CMAKE_OSX_ARCHITECTURES was found in cmake extra defines. 7. Removed a small piece of code in build.py, which was for support CUDA version < 11.8. 8. Fixed an issue that CMAKE_OSX_ARCHITECTURES sometimes got specified twice when build.py invoked cmake. 9. Added more model tests to Android build. After this change, we will test all ONNX versions instead of just the latest one. 10. Fixed issues that are related to build.py's "--build_nuget" parameter. Also, enable the flag in most Windows CPU CI build jobs. 11. Removed a restriction in build.py that disallowed cross-compiling Windows ARM64 nuget package on Windows x86. ### Motivation and Context Adopt vcpkg.

The extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like: ``` CMake Error at cmake_install.cmake:47 (include): include could not find requested file: /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake ``` When running "make install" command after successfully building onnxruntime without vcpkg. The issue doesn't exist when vcpkg is enabled.

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jan 25, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jan 25, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

github-actions bot reviewed Jan 25, 2025

View reviewed changes

tools/ci_build/build.py Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Jan 30, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jan 30, 2025

View reviewed changes

cmake/vcpkg-triplets/gen.py Fixed Show fixed Hide fixed

init commit

dc4bf72

snnn force-pushed the snnn/vcpkg2 branch from 17edb3f to dc4bf72 Compare January 31, 2025 20:50

github-advanced-security bot found potential problems Jan 31, 2025

View reviewed changes

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

tools/ci_build/build.py Fixed Show fixed Hide fixed

snnn added 14 commits January 31, 2025 13:05

update

5c5e7f4

update

1cad56e

update

87ab21b

update

28a780f

update

d141062

update

91dc288

update

219416a

Update c-api-noopenmp-packaging-pipelines.yml

17857b2

update

a2177c6

update

06b5761

update

44467af

update

a32a5df

Enable VCPKG in Windows CI pipelines

79e1716

update

38ae8ab

snnn force-pushed the snnn/vcpkg2 branch from 56e2a57 to 38ae8ab Compare February 4, 2025 02:08

snnn added 5 commits February 4, 2025 19:04

Update

aa81f07

update

0da2ed2

Merge remote-tracking branch 'origin/main' into snnn/vcpkg2

515791c

update

b299fb8

update

4662fc8

snnn added 2 commits February 4, 2025 21:51

update

faaf6ab

update

a96041b

snnn marked this pull request as ready for review February 5, 2025 16:11

snnn mentioned this pull request Feb 5, 2025

[Build] [MIGraphX EP][ ROCm EP] LD_LIBRARY_PATH/RPATH not set correctly for newer wheels generated within a pyenv environment #23584

Closed

jchen351 approved these changes Feb 5, 2025

View reviewed changes

snnn merged commit 5f6a315 into main Feb 5, 2025
238 of 239 checks passed

snnn deleted the snnn/vcpkg2 branch February 5, 2025 18:58

snnn mentioned this pull request Feb 11, 2025

Fix an installation issue related to absl #23641

Merged

ashrit-ms mentioned this pull request Feb 11, 2025

Update win-ort-main to tip main 250211 #23646

Merged

zwassall-gentuity mentioned this pull request Feb 28, 2025

Synchronize patch files, fix resource compiler invocations in some situations #23855

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable VCPKG in CI build #23426

Enable VCPKG in CI build #23426

Uh oh!

snnn commented Jan 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zwassall-gentuity commented Feb 28, 2025 •

edited

Loading

Uh oh!

snnn commented Feb 28, 2025

Uh oh!

Uh oh!

Enable VCPKG in CI build #23426

Enable VCPKG in CI build #23426

Uh oh!

Conversation

snnn commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zwassall-gentuity commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snnn commented Feb 28, 2025

Uh oh!

Uh oh!

snnn commented Jan 18, 2025 •

edited

Loading

zwassall-gentuity commented Feb 28, 2025 •

edited

Loading