-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webgpu] Implement Split operator #23198
base: main
Are you sure you want to change the base?
Conversation
Test: onnxruntime_test_all.exe --gtest_filter=SplitOperatorTest.*
@jchen10 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
||
class Split : public WebGpuKernel, public SplitBase { | ||
public: | ||
Split(const OpKernelInfo& info, uint32_t opset) : WebGpuKernel(info), SplitBase(info, opset) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do some validation in the Split
constructor function, not in the ComputeInternal
function? I see PrepareForCompute
has already done some the same validation.
Test: onnxruntime_test_all.exe --gtest_filter=SplitOperatorTest.*
Description
Motivation and Context