Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebNN EP] Remove workaround for scalar #21704

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Aug 12, 2024

Currently Chromium has supported scalar with dims = {}, remove legacy workaround for supporting scalar.

Currently Chromium has supported scalar with dims = {},
remove legacy workaround for supporting scalar.
@Honry
Copy link
Contributor Author

Honry commented Aug 12, 2024

@fdwr, @guschmue, PTAL, thanks!

Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup - one less workaround 🧼.

@fdwr fdwr added the ep:WebNN WebNN execution provider label Aug 12, 2024
@fdwr
Copy link
Contributor

fdwr commented Aug 12, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 12, 2024

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 12, 2024

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Aug 15, 2024

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@fdwr fdwr merged commit b2d603a into microsoft:main Aug 16, 2024
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants