Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebNN EP] Create MLGraphBuilder for every model builder #21514

Merged
merged 2 commits into from
Aug 1, 2024
Merged

[WebNN EP] Create MLGraphBuilder for every model builder #21514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74c63bb
[WebNN EP] Create MLGraphBuilder for every model builder
Honry Jul 26, 2024
57dbebb
Release WebNN builder after graph built
Honry Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Release WebNN builder after graph built
  • Loading branch information
@Honry
Honry committed Aug 1, 2024
commit 57dbebb175397fcd1eeaa34bc66883b8a4df09fe
2 changes: 2 additions & 0 deletions onnxruntime/core/providers/webnn/builders/model_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ Status ModelBuilder::Compile(std::unique_ptr<Model>& model) {
if (!wnn_graph.as<bool>()) {
return ORT_MAKE_STATUS(ONNXRUNTIME, FAIL, "Failed to build WebNN graph.");
}
// Explicitly release the WebNN builder to free memory.
wnn_builder_ = emscripten::val::undefined();
model.reset(new Model(std::move(wnn_context_), std::move(wnn_graph), logger_));
model->SetInputs(std::move(input_names_));
model->SetOutputs(std::move(output_names_));
Expand Down
5 changes: 1 addition & 4 deletions onnxruntime/core/providers/webnn/builders/model_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ class ModelBuilder {
ModelBuilder(const GraphViewer& graph_viewer, const logging::Logger& logger,
const emscripten::val& context, const DataLayout preferred_layout,
const WebnnDeviceType wnn_device_type);
~ModelBuilder() {
// Explicitly release the WebNN builder to free memory.
wnn_builder_ = emscripten::val::undefined();
};
~ModelBuilder() = default;

Status Compile(std::unique_ptr<Model>& model) ORT_MUST_USE_RESULT;

Expand Down
Loading