[WebNN EP] Add outputDataType option for the ArgMax/ArgMin ops by Honry · Pull Request #21385 · microsoft/onnxruntime

Honry · 2024-07-17T09:11:17Z

Description

WebNN spec introduces a new option: outputDataType to argMax and argMin ops, it's default value is int32, we should explicitly set it to int64 for WebNN EP.

Spec CR: "Add outputDataType to argmin/argmax" webmachinelearning/webnn#730

Honry · 2024-07-17T09:12:25Z

@fdwr, @guschmue, PTAL, thanks!

cc/ @huningxin

fdwr · 2024-07-17T21:55:46Z

@Honry Thank you for updating it promptly to match the Chromium implementation.

fdwr · 2024-07-17T21:56:19Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-17T21:56:23Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-17T21:56:29Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-17T21:56:36Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-17T21:56:57Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2024-07-17T21:57:01Z

Azure Pipelines successfully started running 7 pipeline(s).

fdwr · 2024-07-18T00:52:36Z

/azp run Windows GPU CI Pipeline

azure-pipelines · 2024-07-18T00:52:46Z

Azure Pipelines successfully started running 1 pipeline(s).

huningxin

LGTM with a comment

fdwr · 2024-07-18T05:41:59Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-18T05:42:05Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-18T05:42:11Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-18T05:42:17Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-18T05:42:40Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2024-07-18T05:42:40Z

Azure Pipelines successfully started running 9 pipeline(s).

fdwr · 2024-07-19T02:02:17Z

/azp run Windows GPU TensorRT CI Pipeline

fdwr · 2024-07-19T02:02:42Z

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline

fdwr · 2024-07-19T02:31:26Z

@Honry I don't know why the GPU tests keep getting canceled. Maybe there is a change in main we should merge into this branch?

Honry · 2024-07-19T02:33:48Z

@Honry I don't know why the GPU tests keep getting canceled. Maybe there is a change in main we should merge into this branch?

I will do a rebase.

Honry · 2024-07-19T02:35:31Z

@Honry I don't know why the GPU tests keep getting canceled. Maybe there is a change in main we should merge into this branch?

I will do a rebase.

@fdwr, done, please help retrigger the CI.

fdwr · 2024-07-19T02:36:46Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

fdwr · 2024-07-19T02:36:58Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-19T02:37:12Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

guschmue · 2024-07-19T15:41:53Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

guschmue · 2024-07-19T15:42:00Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

guschmue · 2024-07-19T15:42:07Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-19T15:42:11Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-19T15:42:35Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2024-07-19T15:42:35Z

Azure Pipelines successfully started running 7 pipeline(s).

fdwr · 2024-07-20T01:01:33Z

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline

azure-pipelines · 2024-07-20T01:01:47Z

Azure Pipelines successfully started running 2 pipeline(s).

huningxin mentioned this pull request Jul 17, 2024

[Stable Diffusion1_5][WebNN GPU] Failed to execute 'add' on 'MLGraphBuilder': The input operand data types don't match. microsoft/webnn-developer-preview#16

Closed

fdwr added the ep:WebNN WebNN execution provider label Jul 17, 2024

fdwr previously approved these changes Jul 17, 2024

View reviewed changes

fdwr mentioned this pull request Jul 18, 2024

[Segment Anything][WebNN GPU] Failed to execute 'compute' on 'MLContext': Invalid outputs: The type (BigInt64) of the array buffer view microsoft/webnn-developer-preview#17

Closed

huningxin approved these changes Jul 18, 2024

View reviewed changes

Comment thread onnxruntime/core/providers/webnn/builders/impl/argmax_min_op_builder.cc

Honry dismissed fdwr’s stale review via 6920447 July 18, 2024 02:38

fdwr previously approved these changes Jul 19, 2024

View reviewed changes

[WebNN EP] Add outputDataType option for the ArgMax/ArgMin ops

ca89be0

Honry dismissed fdwr’s stale review via ca89be0 July 19, 2024 02:34

Honry force-pushed the argmaxmin-outputDataType branch from 6920447 to ca89be0 Compare July 19, 2024 02:34

fdwr approved these changes Jul 22, 2024

View reviewed changes

fdwr merged commit 17e9ea6 into microsoft:main Jul 22, 2024

ibelem mentioned this pull request Jul 23, 2024

Fix #16 #17 Add outputDataType option for the ArgMax/ArgMin ops microsoft/webnn-developer-preview#19

Merged

1 task

Uh oh!

Conversation

Honry commented Jul 17, 2024 • edited by fdwr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Honry commented Jul 17, 2024

Uh oh!

fdwr commented Jul 17, 2024

Uh oh!

fdwr commented Jul 17, 2024

Uh oh!

fdwr commented Jul 17, 2024

Uh oh!

fdwr commented Jul 17, 2024

Uh oh!

azure-pipelines Bot commented Jul 17, 2024

Uh oh!

azure-pipelines Bot commented Jul 17, 2024

Uh oh!

azure-pipelines Bot commented Jul 17, 2024

Uh oh!

fdwr commented Jul 18, 2024

Uh oh!

azure-pipelines Bot commented Jul 18, 2024

Uh oh!

huningxin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fdwr commented Jul 18, 2024

Uh oh!

fdwr commented Jul 18, 2024

Uh oh!

fdwr commented Jul 18, 2024

Uh oh!

azure-pipelines Bot commented Jul 18, 2024

Uh oh!

azure-pipelines Bot commented Jul 18, 2024

Uh oh!

azure-pipelines Bot commented Jul 18, 2024

Uh oh!

fdwr commented Jul 19, 2024

Uh oh!

fdwr commented Jul 19, 2024

Uh oh!

fdwr commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Honry commented Jul 19, 2024

Uh oh!

Honry commented Jul 19, 2024

Uh oh!

fdwr commented Jul 19, 2024

Uh oh!

fdwr commented Jul 19, 2024

Uh oh!

fdwr commented Jul 19, 2024

Uh oh!

guschmue commented Jul 19, 2024

Uh oh!

guschmue commented Jul 19, 2024

Uh oh!

guschmue commented Jul 19, 2024

Uh oh!

azure-pipelines Bot commented Jul 19, 2024

Uh oh!

azure-pipelines Bot commented Jul 19, 2024

Uh oh!

azure-pipelines Bot commented Jul 19, 2024

Uh oh!

fdwr commented Jul 20, 2024

Uh oh!

azure-pipelines Bot commented Jul 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Honry commented Jul 17, 2024 •

edited by fdwr

Loading

fdwr commented Jul 19, 2024 •

edited

Loading