Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow causing test failure on x86 #20425

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix overflow causing test failure on x86 #20425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion orttraining/orttraining/training_api/checkpoint.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ Status FromTensorProtos(gsl::span<const ONNX_NAMESPACE::TensorProto> trainable_t
fbs_buffer_size = std::max(fbs_buffer_size, m_bytes);
fbs_buffer_size = ((fbs_buffer_size + m_bytes - 1) / m_bytes) * m_bytes;

const bool use_external_data = fbs_buffer_size >= external_data_threshold * m_bytes;
const bool use_external_data = fbs_buffer_size >= external_data_threshold;

fbs::utils::ExternalDataWriter external_data_writer = nullptr;
std::optional<std::ofstream> external_data_stream;
Expand Down
Loading