Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade old Python version in packaging pipeline #16667

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Upgrade old Python version in packaging pipeline #16667

merged 6 commits into from
Jul 17, 2023
+30 −22

Conversation

edgchen1
Copy link
Contributor

Description

  • Upgrade from Python 3.6 to 3.8 in packaging pipeline.
  • Raise build.py minimum required Python version.

Motivation and Context

Stop using unsupported Python version.

@edgchen1 edgchen1 requested review from skottmckay and mszhanyi July 12, 2023 02:33
thiagocrepaldi
thiagocrepaldi reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an extra data point, but the new ONNX exporter based on PyTorch Dynamo has a better model coverage with Python 3.11

It would be nice to start testing this environment in our pipelines for the near future exporter

@edgchen1
Copy link
Contributor Author

Just as an extra data point, but the new ONNX exporter based on PyTorch Dynamo has a better model coverage with Python 3.11

It would be nice to start testing this environment in our pipelines for the near future exporter

Good to know. FYI @microsoft/onnxruntime-es

@edgchen1 edgchen1 requested a review from skottmckay July 13, 2023 21:31
@edgchen1 edgchen1 merged commit df8843c into main Jul 17, 2023
@edgchen1 edgchen1 deleted the edgchen1/upgrade_python branch July 17, 2023 15:24
@snnn snnn mentioned this pull request Aug 18, 2023
Merged
@snnn
Copy link
Member

snnn commented Aug 18, 2023

@thiagocrepaldi , the pipelines he is modifying is not a python pipeline. It is for generating nuget packages. Our python packaging pipeline supports python 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi left review comments

@skottmckay skottmckay skottmckay approved these changes

@mszhanyi mszhanyi Awaiting requested review from mszhanyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgchen1 @snnn @skottmckay @thiagocrepaldi