[ROCm] Update cmake #15807
Merged
[ROCm] Update cmake #15807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhan
force-pushed
the
guangyunhan/rocm-cmake-update
branch
from
85c7d75 to
07ffc74
Compare
snnn
previously approved these changes
May 4, 2023
mszhanyi
approved these changes
May 4, 2023
snnn
approved these changes
May 4, 2023
ShukantPal
pushed a commit
to ShukantPal/onnxruntime
that referenced
this pull request
May 7, 2023
This was referenced May 11, 2023
snnn
added a commit
that referenced
this pull request
May 12, 2023
### Description Cherry-pick the following PRs to the release branch #15858 #15807 #15816 #15775 #15779 They are all clean merges. --------- Co-authored-by: cloudhan <guangyunhan@microsoft.com> Co-authored-by: Sumit Agarwal <sumitagarwal330@gmail.com> Co-authored-by: RandySheriffH <48490400+RandySheriffH@users.noreply.github.com> Co-authored-by: Randy Shuai <rashuai@microsoft.com>
preetha-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 7, 2023
### Description Cherry-pick the following PRs to the release branch microsoft#15858 microsoft#15807 microsoft#15816 microsoft#15775 microsoft#15779 They are all clean merges. --------- Co-authored-by: cloudhan <guangyunhan@microsoft.com> Co-authored-by: Sumit Agarwal <sumitagarwal330@gmail.com> Co-authored-by: RandySheriffH <48490400+RandySheriffH@users.noreply.github.com> Co-authored-by: Randy Shuai <rashuai@microsoft.com>
cloudhan
added a commit
that referenced
this pull request
Jul 10, 2023
#15807 fixed the building error for rocm with cmake 3.26. The specialized relaxation of the cmake version is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #15775