-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java and Objective-C bindings for RegisterCustomOpsUsingFunction. #14256
Merged
edgchen1
merged 6 commits into
main
from
skottmckay/AddJavaObjCBindingsForRegisterCustomOpsUsingFuncName
Jan 13, 2023
Merged
Add Java and Objective-C bindings for RegisterCustomOpsUsingFunction. #14256
edgchen1
merged 6 commits into
main
from
skottmckay/AddJavaObjCBindingsForRegisterCustomOpsUsingFuncName
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
reviewed
Jan 12, 2023
edgchen1
reviewed
Jan 12, 2023
edgchen1
reviewed
Jan 12, 2023
edgchen1
previously approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Objective-C API changes look good. just had some minor doc comments
…. Test is mainly to validate the API can be called. We have native unit tests that validate the symbol can be used when loaded with RTLD_GLOBAL or linked against, so not overcomplicating the unit test for now.
edgchen1
approved these changes
Jan 13, 2023
Craigacp
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Java bits.
edgchen1
deleted the
skottmckay/AddJavaObjCBindingsForRegisterCustomOpsUsingFuncName
branch
January 13, 2023 17:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bindings for Android and iOS.
Motivation and Context
Enable mobile app linking against ort-extensions library and registering the custom ops with ORT.