Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java and Objective-C bindings for RegisterCustomOpsUsingFunction. #14256

Merged

Conversation

skottmckay
Copy link
Contributor

Description

Add bindings for Android and iOS.

Motivation and Context

Enable mobile app linking against ort-extensions library and registering the custom ops with ORT.

edgchen1
edgchen1 previously approved these changes Jan 12, 2023
Copy link
Contributor

@edgchen1 edgchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objective-C API changes look good. just had some minor doc comments

…. Test is mainly to validate the API can be called. We have native unit tests that validate the symbol can be used when loaded with RTLD_GLOBAL or linked against, so not overcomplicating the unit test for now.
@skottmckay skottmckay marked this pull request as ready for review January 12, 2023 23:45
Copy link
Contributor

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Java bits.

@edgchen1 edgchen1 merged commit 114f183 into main Jan 13, 2023
@edgchen1 edgchen1 deleted the skottmckay/AddJavaObjCBindingsForRegisterCustomOpsUsingFuncName branch January 13, 2023 17:04
@faxu faxu removed the release:1.14 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants