Remove protobuf pin from training requirements #13695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
added
the
training
|
It seems we can't upgrade our protobuf version to 3.20.x ? #13335 |
sheetalarkadam
approved these changes
Nov 18, 2022
|
@snnn, I think we could. I didn't see any pipeline failures on onnxruntime-training side for this upgrade. |
askhade
approved these changes
Nov 22, 2022
pranavsharma
approved these changes
Nov 22, 2022
henrywu2019
pushed a commit
to henrywu2019/onnxruntime
that referenced
this pull request
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an earlier pull request #13596, I pinned the protobuf version to
>= 3.20.0, <= 3.21.0with the intention of fixing a build pipeline.But the change did not fix the broken pipeline as can be seen from this run
Moreover, this change had an inadvertent effect on the ACPT nightly pipelines which require protobuf version 3.19.x to meet dependency requirements from other packages.
Moving forward, will keep the
onnxruntime-trainingandonnxruntimerequirements for protobuf the same.