Skip to content

Fix WinML Test Case: create LearningModelBinding for every testcase #13587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Fix WinML Test Case: create LearningModelBinding for every testcase #13587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ba91a0
Fix FCN test error
mszhanyi Nov 8, 2022
4fb8924
code clean
mszhanyi Nov 8, 2022
875a623
rebinding
mszhanyi Nov 8, 2022
895c18f
Merge branch 'main' of https://github.com/microsoft/onnxruntime into …
mszhanyi Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion winml/test/model/model_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ TEST_P(ModelTest, Run) {
WINML_EXPECT_NO_THROW(model = LearningModel::LoadFromFilePath(m_testCase->GetModelUrl()));
WINML_EXPECT_NO_THROW(device = LearningModelDevice(m_deviceKind));
WINML_EXPECT_NO_THROW(session = LearningModelSession(model, device));
WINML_EXPECT_NO_THROW(binding = LearningModelBinding(session));
for (size_t i = 0; i < m_testCase->GetDataCount(); i++) {
// Load and bind inputs
WINML_EXPECT_NO_THROW(binding = LearningModelBinding(session));
onnxruntime::test::HeapBuffer inputHolder;
std::unordered_map<std::string, Ort::Value> inputFeeds;
WINML_EXPECT_NO_THROW(m_testCase->LoadTestData(i, inputHolder, inputFeeds, true));
Expand All @@ -129,6 +129,8 @@ TEST_P(ModelTest, Run) {
// evaluate
LearningModelEvaluationResult results = nullptr;
WINML_EXPECT_NO_THROW(results = session.Evaluate(binding, L"Testing"));
binding.Clear();
binding = nullptr;

// Load expected outputs
onnxruntime::test::HeapBuffer outputHolder;
Expand Down
2 changes: 0 additions & 2 deletions winml/test/model/skip_model_tests.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ std::unordered_map<std::string, std::string> disabledTests(
{"Inception_1_int8_opset12_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"Faster_R_CNN_R_50_FPN_int8_opset12_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"BERT_Squad_int8_opset12_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"FCN_ResNet_50_opset11_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"FCN_ResNet_101_opset11_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"EfficientNet_Lite4_qdq_opset11_zoo_CPU", "https://github.com/onnx/models/issues/568"},
{"EfficientNet_Lite4_int8_opset11_zoo_CPU", "https://github.com/onnx/models/issues/568"},
}
Expand Down