Rewrite the fns_candy_style_transfer example so that it doesn't depends on libpng on Windows #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
Oct 25, 2022
| if(WIN32) | ||
| target_sources(fns_candy_style_transfer PRIVATE image_file_wic.cc) | ||
| else() | ||
| target_sources(fns_candy_style_transfer PRIVATE image_file_libpng.c) |
Contributor
There was a problem hiding this comment.
my understanding is that libpng things (PNG_LIBRARIES, PNG_INCLUDE_DIRS, PNG_LIBDIR) aren't used on windows. perhaps it would be clearer to put them in this block?
| done | ||
|
|
||
| apt-get update | ||
| apt-get install -y cmake gcc g++ libpng-dev libjpeg-turbo8-dev curl |
Contributor
There was a problem hiding this comment.
nit: this is not really part of "downloading ORT", maybe it could go in a separate script or this one could be renamed
| FAIL_FAST_IF_FAILED(decoder->GetFrameCount(&count)); | ||
| if (count != 1) { | ||
| printf("The image has multiple frames, I don't know which to choose.\n"); | ||
| abort(); |
Member
Author
There was a problem hiding this comment.
Thanks! I updated the code.
edgchen1
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$sign in front of it.