Fix build errors #145
Open
Fix build errors #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavsharma
force-pushed
the
FixBuildErrors
branch
from
3812aed to
124866d
Compare
snnn
reviewed
Sep 23, 2022
|
The build failures are expected. I will refactor the pipelines to let them fetch bits from our ORT-Nightly feed to fix the issues. |
snnn
reviewed
Oct 25, 2022
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/cpu" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/cuda" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/dnnl" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/nuphar" |
There was a problem hiding this comment.
nuphar is deleted from the latest ORT.
snnn
reviewed
Oct 25, 2022
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/tensorrt" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/dml" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/providers/migraphx" | ||
| "${ONNXRUNTIME_ROOTDIR}/include/onnxruntime/core/session") |
There was a problem hiding this comment.
So, it means we need to list all EPs here? Why?
If I understood correctly, ONNXRUNTIME_ROOTDIR is where ORT is installed, not the source folder. At the installation step, should we already put all the EP specific header files into one place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [Build] Onnxruntime C++ samples do not build off Cmake installed onnxruntime onnxruntime#13058