Add custom model path support for unit tests #1917
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anujj Please help review |
mpasumarthi-git
force-pushed
the
mpasumarthi/custom-model-path
branch
from
6c366c7 to
bce7d76
Compare
kunal-vaishnavi
approved these changes
Jan 8, 2026
baijumeswani
reviewed
Jan 8, 2026
Collaborator
baijumeswani
left a comment
baijumeswani
left a comment
There was a problem hiding this comment.
Is there an external script that is used to call the unit tests that passes in different models to the test? What is the use case of passing in a custom model?
|
|
||
| // Parse custom model path argument | ||
| for (int i = 1; i < argc; ++i) { | ||
| std::string arg = argv[i]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::string arg = argv[i]; | |
| const std::string arg = argv[i]; |
Collaborator
There was a problem hiding this comment.
Might also be a good idea to parse the args after InitGoogleTest to avoid accidentally touching gtest args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom model paths in unit tests via command-line argument
--model_pathargument tounit_tests.exeto specify custom model locationstest/main.cppto parse the custom model path argumenttest/model_tests.cpp,test/sampling_benchmark.cpp, andtest/sampling_tests.cppto use custom paths for NvTensorRT tests