Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
Removing the dependency on the deployment script on the bicep output variables.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@nharper285 nharper285 changed the title User/noharper/remove storage key dependency Remove storage key dependency from deployment script Oct 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #3574 (bf50f78) into main (7afe06a) will decrease coverage by 5.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3574      +/-   ##
==========================================
- Coverage   44.31%   39.00%   -5.32%     
==========================================
  Files         166      302     +136     
  Lines       22207    36959   +14752     
==========================================
+ Hits         9842    14417    +4575     
- Misses      12365    22542   +10177     

see 137 files with indirect coverage changes

@nharper285 nharper285 marked this pull request as ready for review October 17, 2023 21:16
@nharper285 nharper285 merged commit 679309a into microsoft:main Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants