Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@Porges
Copy link
Member

@Porges Porges commented Aug 10, 2023

Make crashdumps optional in task definition so that old CLI clients are not rejected.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #3409 (d65a141) into main (9420f51) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3409      +/-   ##
==========================================
- Coverage   34.20%   34.18%   -0.02%     
==========================================
  Files         297      297              
  Lines       36406    36423      +17     
==========================================
  Hits        12452    12452              
- Misses      23954    23971      +17     
Files Changed Coverage Δ
src/ApiService/ApiService/onefuzzlib/Defs.cs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/local/libfuzzer_fuzz.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/local/template.rs 6.35% <0.00%> (ø)
...nt/onefuzz-task/src/tasks/fuzz/libfuzzer/common.rs 17.28% <0.00%> (-0.35%) ⬇️
...rc/agent/onefuzz-task/src/tasks/fuzz/supervisor.rs 0.00% <0.00%> (ø)

@Porges Porges marked this pull request as ready for review August 17, 2023 04:31
@Porges
Copy link
Member Author

Porges commented Aug 17, 2023

Validated with check-pr

@Porges Porges enabled auto-merge (squash) August 17, 2023 04:31
@Porges Porges merged commit b45446a into main Aug 17, 2023
@Porges Porges deleted the crashdumps-optional branch August 17, 2023 20:09
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants