Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@AdamL-Microsoft
Copy link
Contributor

@AdamL-Microsoft AdamL-Microsoft commented Aug 9, 2023

Summary of the Pull Request

This PR is to resolve this Az login issue Azure/azure-cli#27131

Info on Pull Request

updated:

  • src/cli/requirements.txt
  • src/deployment/requirements.txt
  • src/utils/add-corpus-storage-accounts/requirements.txt
  • src/utils/check-pr/requirements.txt

Validation Steps Performed

✅ Passed all check-pr integration tests and CLI tests

Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #3396 (33c1335) into main (9c0a344) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3396   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files         297      297           
  Lines       36250    36250           
=======================================
  Hits        12450    12450           
  Misses      23800    23800           

@AdamL-Microsoft AdamL-Microsoft marked this pull request as ready for review August 9, 2023 19:27
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine but I'd run a check-pr with the CLI validation step just to be sure

@AdamL-Microsoft AdamL-Microsoft merged commit ef0cfbf into microsoft:main Aug 9, 2023
@AdamL-Microsoft AdamL-Microsoft deleted the update-check-pr-requirement branch August 9, 2023 21:01
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants