Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@kananb
Copy link
Contributor

@kananb kananb commented Jul 25, 2023

Summary of the Pull Request

#3234

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

Adds code to look for azcopy.exe inside of AZCOPY if it's a directory and prints a nice error if azcopy.exe can't be found.

Validation Steps Performed

Set AZCOPY to a directory containing azcopy.exe and observe that commands work as expected.
Set AZCOPY to a directory not containing azcopy.exe and observe that an informative error is printed out.
Set AZCOPY to a path pointing to azcopy.exe and observe that commands work as expected.
Set AZCOPY to a path pointing to an azcopy.exe that doesn't exist and observe that an informative error is printed out.

@kananb kananb requested a review from Porges July 25, 2023 22:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #3344 (e0c100b) into main (6ea2faa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3344   +/-   ##
=======================================
  Coverage   31.66%   31.66%           
=======================================
  Files         308      308           
  Lines       37609    37609           
=======================================
  Hits        11909    11909           
  Misses      25700    25700           

kananb and others added 2 commits July 26, 2023 07:45
@kananb kananb force-pushed the kanan/azcopy-env branch from 7d0e2f7 to 4557b43 Compare July 26, 2023 14:45
@kananb kananb merged commit ed4c02a into main Jul 26, 2023
@kananb kananb deleted the kanan/azcopy-env branch July 26, 2023 16:00
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants