Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@kananb
Copy link
Contributor

@kananb kananb commented Jul 25, 2023

Summary of the Pull Request

#3338
onefuzz repro get_files only handles reports and not regression_reports.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

Adds logic for checking that the fields expected in a normal report exist before falling back on fields expected from a regression report. An error is logged otherwise.

Validation Steps Performed

How does someone test & validate?

@kananb kananb requested review from mgreisen and tevoinea July 25, 2023 17:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #3340 (e5adcdf) into main (62c3f07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3340   +/-   ##
=======================================
  Coverage   31.83%   31.83%           
=======================================
  Files         307      307           
  Lines       37358    37358           
=======================================
  Hits        11894    11894           
  Misses      25464    25464           

@kananb kananb merged commit 73e21e9 into main Jul 25, 2023
@kananb kananb deleted the kanan/regression-repro branch July 25, 2023 20:26
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants