This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Fix resolution of sibling .NET DLLs #3325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
- Coverage 31.80% 30.40% -1.41%
==========================================
Files 307 133 -174
Lines 37334 14285 -23049
==========================================
- Hits 11874 4343 -7531
+ Misses 25460 9942 -15518 |
Porges
changed the title
tevoinea
approved these changes
Jul 24, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
LibFuzzerDotNetLoaderloads DLLs that have dependencies, they are not currently resolved correctly, as sibling DLLs in the same directory are not considered. In order to do this, we need to provide a customAssemblyLoadContext. This PR does so, based on the dotnet core example code.Validated with custom fuzzer implementation; we don't yet have a full test for this in check-pr.
Closes #3326.