This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Cache FindContainer #3304
Merged
Cache FindContainer #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3304 +/- ##
==========================================
+ Coverage 29.99% 31.78% +1.79%
==========================================
Files 133 307 +174
Lines 14180 37312 +23132
==========================================
+ Hits 4253 11860 +7607
- Misses 9927 25452 +15525
|
Porges
commented
Jul 19, 2023
Porges
commented
Jul 20, 2023
Porges
commented
Jul 20, 2023
chkeita
approved these changes
Jul 20, 2023
Porges
added a commit
that referenced
this pull request
Jul 24, 2023
Noticed a few things while doing #3304, so fixing them in another PR: - Add `CreateNewContainer` which will always create a new container instead of looking for one first. - InstanceId was not being cached properly (the Lazy would be recreated upon every request) — my fault! - Add `GetBlob` beside `GetBlogWithTags` for when we don't need the tags - Make `GetBlogWithTags` do both fetches in parallel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3156.
From now on, we will store additional information about containers in a table (
ContainerInformation). This is populated when a container is created, or lazily when looking for a container we have not yet stored in the table.Reads from this table are also cached in memory for a short period of time (currently 10 minutes).
The table is currently used to speed up lookups for containers across storage accounts; we round-robin creation of containers across multiple storage accounts to spread load, so when we read from a container we need to find what storage account it lives in.
The
ContainerInformationtable could also be used in future to store information about access control (see, e.g. #1419).