Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@Porges
Copy link
Member

@Porges Porges commented Jun 18, 2023

Caches are getting too big and we are exceeding the 10GB limit, leading to cache churning.

  1. Try to make the caches smaller by using Swatinem/rust-cache, which is smarter about what gets cached.

    • After doing this it turns out we don't really need sccache any more, it has very little impact upon compile times as the cache hit ratio is low. So remove it, to reduce complexity of build and size of build caches.
  2. Also fix artifact caching which had been broken by a version format change (4956cf5).

@Porges Porges force-pushed the caching-improvements branch from fa14dd4 to ff1b9fe Compare June 18, 2023 23:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #3197 (ad60413) into main (b1b7cf0) will increase coverage by 3.90%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
+ Coverage   25.63%   29.53%   +3.90%     
==========================================
  Files         152      332     +180     
  Lines       16289    39060   +22771     
==========================================
+ Hits         4175    11535    +7360     
- Misses      12114    27525   +15411     
Impacted Files Coverage Δ
src/agent/onefuzz/src/libfuzzer.rs 68.26% <91.66%> (ø)

... and 179 files with indirect coverage changes

@Porges Porges changed the title Caching improvements Rust build caching improvements & fixes Jun 19, 2023
@Porges Porges marked this pull request as ready for review June 19, 2023 00:47
@Porges Porges force-pushed the caching-improvements branch from 424d34b to 5ba0876 Compare June 19, 2023 00:47
@Porges Porges enabled auto-merge (squash) June 19, 2023 01:46
@Porges Porges merged commit 28e36ef into main Jun 19, 2023
@Porges Porges deleted the caching-improvements branch June 19, 2023 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants