Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@tevoinea
Copy link
Member

@tevoinea tevoinea commented Feb 24, 2023

Summary of the Pull Request

What is this about?

Closes #2769
Closes #2768

Creates a 2 way communication channel between the onefuzz-agent and the onefuzz-task binaries.

Info on Pull Request

What does this include?

  • When the agent starts a task, it includes paths for the task to connect 2 IPC channels:
    • agent -> task
    • task -> agent
  • Each task invocation will bootstrap a separate set of channels so the collocated task scenario is supported
  • The agent waits up to 30 seconds for the task to complete the IPC channel bootstrap
  • When it comes time to shutdown, the task has 90 seconds to terminate after the shutdown message is sent, otherwise we kill it

Validation Steps Performed

How does someone test & validate?

  • Updated tests and tested locally using unmanaged nodes feature

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #2886 (6f68ede) into main (8a7a0b0) will increase coverage by 0.15%.
The diff coverage is 56.74%.

@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   28.06%   28.22%   +0.15%     
==========================================
  Files         302      303       +1     
  Lines       35811    36013     +202     
==========================================
+ Hits        10050    10164     +114     
- Misses      25761    25849      +88     
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/scheduler.rs 53.80% <0.00%> (ø)
src/agent/onefuzz-task/src/local/common.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/managed/cmd.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/config.rs 0.00% <ø> (ø)
src/agent/onefuzz-task/src/tasks/fuzz/generator.rs 0.00% <0.00%> (ø)
...rc/agent/onefuzz-task/src/tasks/fuzz/supervisor.rs 0.00% <0.00%> (ø)
src/agent/onefuzz/src/lib.rs 100.00% <ø> (ø)
src/agent/onefuzz-agent/src/worker.rs 55.14% <52.63%> (-1.62%) ⬇️
src/agent/onefuzz-agent/src/worker/double.rs 86.36% <70.00%> (-13.64%) ⬇️
src/agent/onefuzz-agent/src/worker/tests.rs 95.78% <84.81%> (-3.45%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea requested review from Porges and chkeita March 1, 2023 15:59
@tevoinea tevoinea requested a review from chkeita March 1, 2023 21:27
@tevoinea tevoinea enabled auto-merge (squash) March 3, 2023 18:30
@tevoinea tevoinea disabled auto-merge March 3, 2023 18:38
@tevoinea tevoinea merged commit 091c870 into main Mar 3, 2023
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
tevoinea added a commit that referenced this pull request Mar 6, 2023
tevoinea added a commit that referenced this pull request Mar 6, 2023
* Revert "Create 2 way IPC connection between agent and task (#2886)"

This reverts commit 091c870.

* Temporarily allow vulnerability since a new one just came out

* Temporarily allow vulnerability

* Update proxy.sh

* Update agent.sh

* Update deny.toml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graceful shutdown Create a communication channel between onefuzz-agent and onefuzz-task

5 participants