This repository was archived by the owner on Nov 1, 2023. It is now read-only.
rename client_id in pool to object_id #2673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
- Coverage 29.31% 29.10% -0.21%
==========================================
Files 291 284 -7
Lines 36166 34550 -1616
==========================================
- Hits 10603 10057 -546
+ Misses 25563 24493 -1070
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
commented
Dec 9, 2022
chkeita
commented
Dec 9, 2022
chkeita
requested review from
Porges and
tevoinea
and removed request for
tevoinea
tevoinea
reviewed
Dec 12, 2022
tevoinea
reviewed
Dec 12, 2022
tevoinea
approved these changes
Dec 12, 2022
Member
tevoinea
left a comment
tevoinea
left a comment
There was a problem hiding this comment.
Just the column rename question
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Currently the Pool has an optional field for the
client_idmeant to be used in the unmanaged node scenario to identify the agent. It is associated with an application registration.This PR replaces it with the
object idof the service principal associated with that application registration.This gives us more flexibility giving us the ability to use a managed identity as the authentication method in the unmanaged case.
This PR also updates the authentication logic to also include the reason for rejecting a request.
The agent logic is also updated to give the content of the response body when a request fails.
Note: The client_id can safely be removed from the pool record because it is not currently used