Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@tevoinea
Copy link
Member

@tevoinea tevoinea commented Mar 8, 2022

Summary of the Pull Request

What is this about?

In #1693, we removed the Onefuzz Deployment custom role since we can't rely on it being in any arbitrary azure tenant. In order to give the Functions App permissions to create the auto scale resources, we're giving it Contributor access to the resource group. Unfortunately, we can't scope down the permissions further since there's no other built-in roles that provide Microsoft.Insights/autoscalesettings/Write permission.

Docs used for resource scoped role assignment: https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-template#resource-group-scope-without-parameters

PR Checklist

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

  • Ran dev deployment and validated the Function App now has Contributor role

@tevoinea tevoinea enabled auto-merge (squash) March 9, 2022 17:17
@tevoinea tevoinea disabled auto-merge March 9, 2022 17:19
@tevoinea tevoinea merged commit 40b0e66 into microsoft:main Mar 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use tenant agnostic role for providing Microsoft.Insights/autoscalesettings/Write permission

3 participants