This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Add fuzzer_target_options to libfuzzer basic template
#1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stishkin
approved these changes
Jan 24, 2022
chkeita
approved these changes
Jan 24, 2022
chkeita
reviewed
Jan 24, 2022
hayleycall
approved these changes
Jan 26, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
fuzzer_target_optionsargument to the libfuzzer templates to enable setting some libfuzzer arguments only when invoked in fuzzing mode.Tested the matrix of
{target_options = None, [x=y]} x {fuzzer_target_options = None, [x=y]}}by creating jobs with thelibfuzzer basictemplate. Verified that all 4 cases look as expected by querying the created tasks and examining their configs. In particular, thecoveragetask should always have{input}added to it (because it is not LibFuzzer-aware), and in all cases, thefuzzer_target_optionsvalues should be appended to the job-widetarget_optionsfor thelibfuzzer_fuzztask only, and omitted for all others. Thedotnetandqemu_usertemplates were tested with the same matrix.Closes #1437.